Delete plugin in Patcher doesn't work anymore

mauro · 27 November 2018 14:12

I don’t know if this has been solved in your latest updates, but on my local version I cannot delete a plugin from the Cabbage Patcher window. The ‘Delete this plugin’ option in the contextual menu doesn’t work.

Then I found this commented section of the audiograph.cpp file:

github.com

rorywalsh/cabbage/blob/9f09412c31d4bb7f07c40769f33b399dc43fbd5c/Source/Audio/Graph/AudioGraph.cpp#L455-L477


void AudioGraph::removeFilter (const AudioProcessorGraph::NodeID id)

{

    jassertfalse;

    //closeCurrentlyOpenWindowsFor (id);

//    AudioProcessorGraph::Node::Ptr n = graph.getNodeForId(id);

//

//    const String pluginFilename = n->properties.getWithDefault("pluginFile", "").toString();

//

//    if (graph.removeNode (id))

//    {

////        for ( int i = 0 ; i < owner.getNumberOfFileTabs() ; i++)

////        {

////            if (int32 (owner.getFileTab(i)->uniqueFileId == id))

////            {

////                remove file tab from array;

////                break;

////            }

////        }

//

//        changed();

This file has been truncated. show original

If I uncomment the commented section then the ‘Delete this plugin’ command returns to work…

rorywalsh · 27 November 2018 20:40

Thanks I had commented that trying to locate a bug I’m seeing in the AudioGraph. I will revisit all of these issues once I have the underlying graph updated.

mauro · 27 November 2018 23:20

Nice. Let me know when there is something to test.